Fix variable shadowing in insertTag causing incorrect tag parameter checks#2
Draft
Fix variable shadowing in insertTag causing incorrect tag parameter checks#2
Conversation
… to htmlTag Co-authored-by: jibin2706 <28289448+jibin2706@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix variable name confusion in insertTag method
Fix variable shadowing in insertTag causing incorrect tag parameter checks
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
insertTagmethod had a local variabletagthat shadowed the method parametertag, causing the conditionif (tag === 'del')at line 152 to check against a formatted HTML tag string (e.g.,'<del>') instead of the parameter value ('del'). This made the condition unreachable.Changes
tagtohtmlTagto eliminate shadowinghtmlTagto thespecialTagDiffStackThe condition at line 167 was unaffected as the local variable was already out of scope.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.